Collect Named Data Store at construction #9370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcr229
requested review from
JacobSzwejbka,
tarun292 and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9370
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit c7f62d5 with merge base 0e5f309 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71407899 |
tarun292
approved these changes
Mar 18, 2025
Summary: EdgeProgramManager should never take in a NamedDataStore, it should always be collected from the EdgePrograms that it recieves. Reviewed By: tarun292 Differential Revision: D71407899
mcr229
force-pushed
the
export-D71407899
branch
from
3016825 to
c518d3f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71407899 |
mcr229
force-pushed
the
export-D71407899
branch
from
c518d3f to
8502617
Compare
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Mar 19, 2025
Summary: EdgeProgramManager should never take in a NamedDataStore, it should always be collected from the EdgePrograms that it recieves. Reviewed By: tarun292 Differential Revision: D71407899
|
This pull request was exported from Phabricator. Differential Revision: D71407899 |
mcr229
force-pushed
the
export-D71407899
branch
from
8502617 to
c7f62d5
Compare
|
@mcr229 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
Differential Revision: D71407899 Pull Request resolved: pytorch#9370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: EdgeProgramManager should never take in a NamedDataStore, it should always be collected from the EdgePrograms that it recieves.
Differential Revision: D71407899